Add supported formats by EXT_color_buffer_float for CopyTexImage2D

Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=712584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2823193002
Cr-Commit-Position: refs/heads/master@{#466069}
Committed: https://chromium.googlesource.com/chromium/src/+/22e0ddbf8f3d503884093b5e14067468e4282841

[qiankun, 2017-04-18 08:54:12]

Description was changed from

==========
Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=
==========

to

==========
Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2017-04-18 08:56:44]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 08:57:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qiankun, 2017-04-18 09:28:12]

Description was changed from

==========
Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=712584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-04-18 09:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 09:39:48]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[qiankun, 2017-04-18 11:17:25]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2017-04-18 11:17:25]

PTAL. The failed conformance test was updated in
https://github.com/KhronosGroup/WebGL/pull/2372..

[Zhenyao Mo, 2017-04-18 17:34:07]

On 2017/04/18 11:17:25, qiankun wrote:
> PTAL. The failed conformance test was updated in
> https://github.com/KhronosGroup/WebGL/pull/2372..

I think you should land the pull request and roll it in first (with failing
tests suppressed)
then land this with tests un-suppressed.

change itself looks good to me.

One question: does command buffer already handle this correctly?

[Ken Russell (switch to Gerrit), 2017-04-20 01:06:49]

LGTM

Agree with Mo that it would be better to roll forward the WebGL conformance
tests, and have this CL remove failure suppressions.

https://codereview.chromium.org/2823193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2823193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:916:
static const GLenum kSupportedInternalFormatsFloat[] = {
These are ES3-specific, so could you name this
kSupportedInternalFormatsFloatES3?

[qiankun, 2017-04-20 07:14:51]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 07:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 09:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 09:26:34]

Dry run: This issue passed the CQ dry run.

[qiankun, 2017-04-20 16:45:55]

I updated the suppressions.
zmo@, the command buffer handles the CopyTexImage API well. I think we can
remove the blink side formats and types validation for TexImage2D and
CopyTexImage2D in future.

https://codereview.chromium.org/2823193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2823193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:916:
static const GLenum kSupportedInternalFormatsFloat[] = {
On 2017/04/20 01:06:48, Ken Russell wrote:
> These are ES3-specific, so could you name this
> kSupportedInternalFormatsFloatES3?

Done.

https://codereview.chromium.org/2823193002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2823193002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:749: ['linux',
'intel'], bug=640389)
This suppression is removed when I roll WebGL to fix conflict with suppressing
this test file on all platforms. Add it back since the suppression for all
platforms is removed.

https://codereview.chromium.org/2823193002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1020: ['linux',
'amd'], bug=633022)
Same here.

[Ken Russell (switch to Gerrit), 2017-04-20 17:59:31]

Let me CQ this for you to save some round-trip time.

https://codereview.chromium.org/2823193002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2823193002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:749: ['linux',
'intel'], bug=640389)
On 2017/04/20 16:45:55, qiankun wrote:
> This suppression is removed when I roll WebGL to fix conflict with suppressing
> this test file on all platforms. Add it back since the suppression for all
> platforms is removed.

Acknowledged.

https://codereview.chromium.org/2823193002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1020: ['linux',
'amd'], bug=633022)
On 2017/04/20 16:45:55, qiankun wrote:
> Same here.

Acknowledged.

[Ken Russell (switch to Gerrit), 2017-04-20 17:59:35]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-04-20 17:59:35]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2823193002/#ps40001
(title: "remove suppressions")

[commit-bot: I haz the power, 2017-04-20 18:00:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 18:06:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492711175346500,
"parent_rev": "a9cdba46ce4367c96aa7c9a0655295a5b8de5992", "commit_rev":
"e4c533b562926dbe191b6cb441c8426950734050"}

[commit-bot: I haz the power, 2017-04-20 18:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492711175346500,
"parent_rev": "d72bac26364de2a1544cf46c2ffa47576dd9aff1", "commit_rev":
"22e0ddbf8f3d503884093b5e14067468e4282841"}

[commit-bot: I haz the power, 2017-04-20 18:06:56]

Description was changed from

==========
Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=712584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add supported formats by EXT_color_buffer_float for CopyTexImage2D

BUG=712584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2823193002
Cr-Commit-Position: refs/heads/master@{#466069}
Committed:
https://chromium.googlesource.com/chromium/src/+/22e0ddbf8f3d503884093b5e1406...
==========

[commit-bot: I haz the power, 2017-04-20 18:06:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/22e0ddbf8f3d503884093b5e1406...