Add supported formats by EXT_color_buffer_float for CopyTexImage2D

third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 894 matching lines @@
     GL_RGBA8_SNORM,
     GL_RGBA16F,
     GL_RGBA32F,
     GL_DEPTH_COMPONENT16,
     GL_DEPTH_COMPONENT24,
     GL_DEPTH_COMPONENT32F,
     GL_DEPTH24_STENCIL8,
     GL_DEPTH32F_STENCIL8,
 };
 
+// Exposed by EXT_color_buffer_float
+static const GLenum kSupportedInternalFormatsFloat[] = {

[Ken Russell (switch to Gerrit), 2017/04/20 01:06:48]

These are ES3-specific, so could you name this
kSupportedInternalFormatsFloatES3?

[qiankun, 2017/04/20 16:45:55]

Done.

+    GL_R16F,    GL_R32F,    GL_RG16F,         GL_RG32F,
+    GL_RGBA16F, GL_RGBA32F, GL_R11F_G11F_B10F};
+
 // ES3 enums supported by TexImageSource
 static const GLenum kSupportedInternalFormatsTexImageSourceES3[] = {
     GL_R8,      GL_R16F,           GL_R32F,         GL_R8UI,    GL_RG8,
     GL_RG16F,   GL_RG32F,          GL_RG8UI,        GL_RGB8,    GL_SRGB8,
     GL_RGB565,  GL_R11F_G11F_B10F, GL_RGB9_E5,      GL_RGB16F,  GL_RGB32F,
     GL_RGB8UI,  GL_RGBA8,          GL_SRGB8_ALPHA8, GL_RGB5_A1, GL_RGBA4,
     GL_RGBA16F, GL_RGBA32F,        GL_RGBA8UI,
 };
 
 // ES2 enums
@@ skipping 129 matching lines @@
       synthesized_errors_to_console_(true),
       num_gl_errors_to_console_allowed_(kMaxGLErrorsAllowedToConsole),
       one_plus_max_non_default_texture_unit_(0),
       is_web_gl2_formats_types_added_(false),
       is_web_gl2_tex_image_source_formats_types_added_(false),
       is_web_gl2_internal_formats_copy_tex_image_added_(false),
       is_oes_texture_float_formats_types_added_(false),
       is_oes_texture_half_float_formats_types_added_(false),
       is_web_gl_depth_texture_formats_types_added_(false),
       is_ext_srgb_formats_types_added_(false),
+      is_ext_color_buffer_float_formats_added_(false),
       version_(version) {
   ASSERT(context_provider);
 
   context_group_->AddContext(this);
 
   max_viewport_dims_[0] = max_viewport_dims_[1] = 0;
   context_provider->ContextGL()->GetIntegerv(GL_MAX_VIEWPORT_DIMS,
                                              max_viewport_dims_);
 
   RefPtr<DrawingBuffer> buffer;
@@ skipping 174 matching lines @@
   for (int i = 0; i < kWebGLExtensionNameCount; ++i)
     extension_enabled_[i] = false;
 
   is_web_gl2_formats_types_added_ = false;
   is_web_gl2_tex_image_source_formats_types_added_ = false;
   is_web_gl2_internal_formats_copy_tex_image_added_ = false;
   is_oes_texture_float_formats_types_added_ = false;
   is_oes_texture_half_float_formats_types_added_ = false;
   is_web_gl_depth_texture_formats_types_added_ = false;
   is_ext_srgb_formats_types_added_ = false;
+  is_ext_color_buffer_float_formats_added_ = false;
 
   supported_internal_formats_.clear();
   ADD_VALUES_TO_SET(supported_internal_formats_, kSupportedFormatsES2);
   supported_tex_image_source_internal_formats_.clear();
   ADD_VALUES_TO_SET(supported_tex_image_source_internal_formats_,
                     kSupportedFormatsES2);
   supported_internal_formats_copy_tex_image_.clear();
   ADD_VALUES_TO_SET(supported_internal_formats_copy_tex_image_,
                     kSupportedFormatsES2);
   supported_formats_.clear();
@@ skipping 864 matching lines @@
 }
 
 bool WebGLRenderingContextBase::ValidateCopyTexFormat(const char* function_name,
                                                       GLenum internalformat) {
   if (!is_web_gl2_internal_formats_copy_tex_image_added_ &&
       IsWebGL2OrHigher()) {
     ADD_VALUES_TO_SET(supported_internal_formats_copy_tex_image_,
                       kSupportedInternalFormatsES3);
     is_web_gl2_internal_formats_copy_tex_image_added_ = true;
   }
+  if (!is_ext_color_buffer_float_formats_added_ &&
+      ExtensionEnabled(kEXTColorBufferFloatName)) {
+    ADD_VALUES_TO_SET(supported_internal_formats_copy_tex_image_,
+                      kSupportedInternalFormatsFloat);
+    is_ext_color_buffer_float_formats_added_ = true;
+  }
 
   if (supported_internal_formats_copy_tex_image_.find(internalformat) ==
       supported_internal_formats_copy_tex_image_.end()) {
     SynthesizeGLError(GL_INVALID_ENUM, function_name, "invalid internalformat");
     return false;
   }
 
   return true;
 }
 
@@ skipping 5710 matching lines @@
 
 void WebGLRenderingContextBase::getHTMLOrOffscreenCanvas(
     HTMLCanvasElementOrOffscreenCanvas& result) const {
   if (canvas())
     result.setHTMLCanvasElement(canvas());
   else
     result.setOffscreenCanvas(offscreenCanvas());
 }
 
 }  // namespace blink