Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2823133002: Clean up some ash constants. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
msw, James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some ash constants. Eliminate a couple instances of TODO(estade). BUG=693282 Review-Url: https://codereview.chromium.org/2823133002 Cr-Commit-Position: refs/heads/master@{#465897} Committed: https://chromium.googlesource.com/chromium/src/+/29fc92dc9444d3012f6259e87dd624bcd5455996

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 4

Patch Set 3 : jamescook review #

Patch Set 4 : fix bad find/replace #

Patch Set 5 : fix typo in test #

Patch Set 6 : ditto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -126 lines) Patch
M ash/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/app_list_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shelf/overflow_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_constants.h View 1 2 chunks +3 lines, -10 lines 0 comments Download
D ash/shelf/shelf_constants.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 3 4 8 chunks +10 lines, -15 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 3 4 3 chunks +5 lines, -8 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/session/logout_button_tray.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/tray/tray_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 4 5 2 chunks +8 lines, -18 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 38 (24 generated)
Evan Stade
msw, ptal chrome_app_delegate.cc jamescook, ptal the rest
3 years, 8 months ago (2017-04-18 15:09:43 UTC) #8
James Cook
LGTM https://codereview.chromium.org/2823133002/diff/20001/ash/shelf/shelf_layout_manager.cc File ash/shelf/shelf_layout_manager.cc (right): https://codereview.chromium.org/2823133002/diff/20001/ash/shelf/shelf_layout_manager.cc#newcode195 ash/shelf/shelf_layout_manager.cc:195: const int shelf_size = kShelfSize; nit: inline uses ...
3 years, 8 months ago (2017-04-18 15:31:53 UTC) #9
Evan Stade
https://codereview.chromium.org/2823133002/diff/20001/ash/shelf/shelf_layout_manager.cc File ash/shelf/shelf_layout_manager.cc (right): https://codereview.chromium.org/2823133002/diff/20001/ash/shelf/shelf_layout_manager.cc#newcode195 ash/shelf/shelf_layout_manager.cc:195: const int shelf_size = kShelfSize; On 2017/04/18 15:31:52, James ...
3 years, 8 months ago (2017-04-18 16:41:09 UTC) #12
msw
chrome_app_delegate.cc lgtm
3 years, 8 months ago (2017-04-18 16:53:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823133002/40001
3 years, 8 months ago (2017-04-18 16:55:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/364933)
3 years, 8 months ago (2017-04-18 17:51:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823133002/60001
3 years, 8 months ago (2017-04-18 20:36:54 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/365170)
3 years, 8 months ago (2017-04-18 21:40:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823133002/80001
3 years, 8 months ago (2017-04-19 15:32:43 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/365944)
3 years, 8 months ago (2017-04-19 16:39:18 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823133002/100001
3 years, 8 months ago (2017-04-19 17:41:33 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/275471)
3 years, 8 months ago (2017-04-19 19:58:45 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823133002/100001
3 years, 8 months ago (2017-04-20 03:40:42 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 04:25:30 UTC) #38
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/29fc92dc9444d3012f6259e87dd6...

Powered by Google App Engine
This is Rietveld 408576698