Issue 2823103002: [Devtools] Fixed cookie size from being off by 1 byte

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2823103002: [Devtools] Fixed cookie size from being off by 1 byte (Closed)

Created:
3 years, 8 months ago by allada

Modified:
3 years, 8 months ago

Reviewers:
dgozman

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Devtools] Fixed cookie size from being off by 1 byte This patch fixes a small bug where the cookie size was always 1 byte less than it really was. R=dgozman BUG=703485

Patch Set 1 #

Patch Set 2 : [Devtools] Fixed cookie size from being off by 1 byte #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -20 lines)			Patch
M	third_party/WebKit/LayoutTests/inspector/components/cookie-parser.html	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt	View	1	10 chunks	+21 lines, -18 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/network/network-cookies-pane-expected.txt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Let's actually not do anything.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages