Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

Issue 2823103002: [Devtools] Fixed cookie size from being off by 1 byte (Closed)
Patch Set: [Devtools] Fixed cookie size from being off by 1 byte Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-cookies-pane-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js b/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
index e1da2a5d6a7540ab49b5251d50c0e075d0ee44fa..de93bda826e69769a2c0e7e4f549e2d55da3a36e 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
@@ -108,6 +108,10 @@ SDK.CookieParser = class {
*/
_initialize(headerValue) {
this._input = headerValue;
+ // We add a \n because the actual header will not exist without a \n at the end. The parser will add
+ // \n between each header, but will not add one at the end (because cookies are a special case header).
+ if (this._input)
+ this._input += '\n';
if (typeof headerValue !== 'string')
return false;
this._cookies = [];
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-cookies-pane-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698