Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt

Issue 2823103002: [Devtools] Fixed cookie size from being off by 1 byte (Closed)
Patch Set: [Devtools] Fixed cookie size from being off by 1 byte Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt
diff --git a/third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt b/third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt
index 87f0c46b678aed3120359965a6a18771e1ab2b4f..0ace581fa0513e0dd83f03c38a5ff8214e8b38ea 100644
--- a/third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt
+++ b/third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt
@@ -1,11 +1,14 @@
Tests inspector cookie parser
+Make sure we always add 1 byte for the trailing \n of the cookie (ie: 4 bytes).
+Should be 4: 4
+
source: cookie=value
-name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 12
+name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 13
{
}
source: $version=1; a=b,c = d, e=f
-name: a, value: b,c = d, e=f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 17
+name: a, value: b,c = d, e=f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 18
{
}
source: $version=1; a=b;c = d; e =f
@@ -15,18 +18,18 @@ name: a, value: b, httpOnly: false, sameSite: undefined, secure: false, session:
name: c, value: d, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 10
{
}
-name: e, value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 4
+name: e, value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 5
{
}
source: cooke1 = value1; another cookie = another value
name: cooke1, value: value1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 25
{
}
-name: cookie, value: another value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 22
+name: cookie, value: another value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 23
{
}
source: cooke1 = value; $Path=/; $Domain=.example.com;
-name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 46
+name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 47
{
domain : ".example.com"
path : "/"
@@ -37,7 +40,7 @@ name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false,
domain : ".example.com"
path : "/"
}
-name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 58
+name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 59
{
domain : "foo.example.com"
path : "/foo"
@@ -49,7 +52,7 @@ name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false,
domain : ".example.com"
path : "/"
}
-name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 59
+name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 60
{
domain : "foo.example.com"
path : "/foo"
@@ -61,13 +64,13 @@ name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false,
domain : ".example.com"
path : "/"
}
-name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 58
+name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 59
{
domain : "foo.example.com"
path : "/foo"
}
source: cookie=value
-name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 12
+name: cookie, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 13
{
}
source: a=b
@@ -79,11 +82,11 @@ name: a, value: b, httpOnly: false, sameSite: undefined, secure: false, session:
name: c, value: d, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 5
{
}
-name: , value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 1
+name: , value: f, httpOnly: false, sameSite: undefined, secure: false, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 2
{
}
source: cooke1 = value; Path=/; Domain=.example.com;
-name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 44
+name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 45
{
domain : ".example.com"
path : "/"
@@ -95,7 +98,7 @@ name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false,
domain : ".example.com"
path : "/"
}
-name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 55
+name: Cookie2, value: value2, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 56
{
domain : "foo.example.com"
path : "/foo"
@@ -107,7 +110,7 @@ name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false,
domain : ".example.com"
expires : "Mon, Oct 18 2010 17:00 GMT+0000"
}
-name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 83
+name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 84
{
discard : undefined
domain : "foo.example.com"
@@ -122,7 +125,7 @@ name: cooke1, value: value, httpOnly: false, sameSite: undefined, secure: false,
domain : ".example.com"
max-age : "1440"
}
-name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 83
+name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true, session: true, path: /foo, domain: foo.example.com, port: undefined, expires: n/a, size: 84
{
discard : undefined
domain : "foo.example.com"
@@ -131,27 +134,27 @@ name: Cookie2, value: value2, httpOnly: true, sameSite: undefined, secure: true,
secure : undefined
}
source: cooke1 = value; HttpOnly; Secure; SameSite=Lax;
-name: cooke1, value: value, httpOnly: true, sameSite: Lax, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 47
+name: cooke1, value: value, httpOnly: true, sameSite: Lax, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 48
{
httponly : undefined
samesite : "Lax"
secure : undefined
}
source: cooke1 = value; HttpOnly; Secure; SameSite=Secure;
-name: cooke1, value: value, httpOnly: true, sameSite: Secure, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 50
+name: cooke1, value: value, httpOnly: true, sameSite: Secure, secure: true, session: true, path: undefined, domain: undefined, port: undefined, expires: n/a, size: 51
{
httponly : undefined
samesite : "Secure"
secure : undefined
}
source: cooke1; Path=/; Domain=.example.com;
-name: , value: cooke1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 36
+name: , value: cooke1, httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 37
{
domain : ".example.com"
path : "/"
}
source: cooke1=; Path=/; Domain=.example.com;
-name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 37
+name: cooke1, value: , httpOnly: false, sameSite: undefined, secure: false, session: true, path: /, domain: .example.com, port: undefined, expires: n/a, size: 38
{
domain : ".example.com"
path : "/"

Powered by Google App Engine
This is Rietveld 408576698