Test for anything falsey as a fail value for element.accessibleNode. Test for anything truthy as a …

Test for anything falsey as a fail value for element.accessibleNode. Test for anything truthy as a fail value on a static text node's accessibleNode.

BUG=None

Review-Url: https://codereview.chromium.org/2823053002
Cr-Commit-Position: refs/heads/master@{#465756}
Committed: https://chromium.googlesource.com/chromium/src/+/3c1e950bab1695de7e24a75b8ed5d6c413bf949a

[aleventhal, 2017-04-17 19:57:26]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 19:57:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-17 20:58:19]

Ready for review. Added explanations for changes.

https://codereview.chromium.org/2823053002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/accessibility/aom.html (left):

https://codereview.chromium.org/2823053002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/accessibility/aom.html:24: }, "DOM Elements have
an AccessibleNode");
This was passing when it shouldn't, because accessibleNode was undefined.

https://codereview.chromium.org/2823053002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/accessibility/aom.html:31: }, "DOM Text nodes do
not have an AccessibleNode.");
The description of this test is opposite from what's being tested, and we should
also care about the  undefined case.

[aleventhal, 2017-04-17 20:59:57]

Description was changed from

==========
Test for anything falsey as a fail value for element.accessibleNode. Test for
anything truthy as a fail value on a static text node's accessibleNode.

BUG=None
==========

to

==========
Test for anything falsey as a fail value for element.accessibleNode. Test for
anything truthy as a fail value on a static text node's accessibleNode.

BUG=None
==========

[aleventhal, 2017-04-17 20:59:57]

aleventhal@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-04-17 21:37:00]

Looks good, but let's wait to land this until after I get the
tests running again. Thanks.

[aleventhal, 2017-04-19 13:10:54]

On 2017/04/17 21:37:00, dmazzoni wrote:
> Looks good, but let's wait to land this until after I get the
> tests running again. Thanks.

Dominic, is this ready now?

[aleventhal, 2017-04-19 19:28:41]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 19:29:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 20:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 20:40:40]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-19 21:06:40]

lgtm

Ready to land now, thanks!

[aleventhal, 2017-04-19 21:07:40]

The CQ bit was checked by aleventhal@chromium.org

[commit-bot: I haz the power, 2017-04-19 21:08:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:25:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492636060557890,
"parent_rev": "d022298ae843ae49644fe3b4645f8e0a84b03da6", "commit_rev":
"3c1e950bab1695de7e24a75b8ed5d6c413bf949a"}

[commit-bot: I haz the power, 2017-04-19 21:26:20]

Description was changed from

==========
Test for anything falsey as a fail value for element.accessibleNode. Test for
anything truthy as a fail value on a static text node's accessibleNode.

BUG=None
==========

to

==========
Test for anything falsey as a fail value for element.accessibleNode. Test for
anything truthy as a fail value on a static text node's accessibleNode.

BUG=None

Review-Url: https://codereview.chromium.org/2823053002
Cr-Commit-Position: refs/heads/master@{#465756}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c1e950bab1695de7e24a75b8ed5...
==========

[commit-bot: I haz the power, 2017-04-19 21:26:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3c1e950bab1695de7e24a75b8ed5...