Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: third_party/WebKit/LayoutTests/accessibility/aom.html

Issue 2823053002: Test for anything falsey as a fail value for element.accessibleNode. Test for anything truthy as a … (Closed)
Patch Set: Slightly cleaner assertion syntax Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/accessibility/aom.html
diff --git a/third_party/WebKit/LayoutTests/accessibility/aom.html b/third_party/WebKit/LayoutTests/accessibility/aom.html
index c77de58b0073e0c4b805175188f0138cc2d43e33..0c308068986b227bb5fa8d28fa60d6b674f970dc 100644
--- a/third_party/WebKit/LayoutTests/accessibility/aom.html
+++ b/third_party/WebKit/LayoutTests/accessibility/aom.html
@@ -20,14 +20,14 @@ if (window.internals)
test(function(t) {
var button = document.getElementById("button");
assert_equals(button.nodeType, Node.ELEMENT_NODE);
- assert_not_equals(button.accessibleNode, null);
+ assert_true(Boolean(button.accessibleNode));
}, "DOM Elements have an AccessibleNode");
aleventhal 2017/04/17 20:58:19 This was passing when it shouldn't, because access
test(function(t) {
var button = document.getElementById("button");
var staticText = button.firstChild;
assert_equals(staticText.nodeType, Node.TEXT_NODE);
- assert_not_equals(staticText.accessibleNode, null);
+ assert_false(Boolean(staticText.accessibleNode));
}, "DOM Text nodes do not have an AccessibleNode.");
aleventhal 2017/04/17 20:58:19 The description of this test is opposite from what
test(function(t) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698