Issue 282303007: Don't pretend that text-decoration is a shorthand in computed style.

Issue 282303007: Don't pretend that text-decoration is a shorthand in computed style. (Closed)

Created:
6 years, 7 months ago by andersr

Modified:
6 years, 7 months ago

Reviewers:
rune

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't pretend that text-decoration is a shorthand in computed style. Even when the appropriate runtime flag isn't enabled, we still return the shorthand version of the computed style for 'text-decoration'. For example, for 'text-decoration: underline', we return the computed style 'underline solid rgb(0, 0, 0)', which is correct only when the runtime flag is on. BUG=367091, 342126 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174269

Patch Set 1 #

Patch Set 2 : Add test for stable/experimental. #

Total comments: 2

Patch Set 3 : Improve testcase. #

Patch Set 4 : Same as Patch Set 3, with --no-find-copies #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
A	LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration-expected.txt	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
A	LayoutTests/virtual/stable/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration-expected.txt	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

andersr

I guess it's not possible to create a regression test for this?

6 years, 7 months ago (2014-05-16 12:19:05 UTC) #1

rune

On 2014/05/16 12:19:05, andersr wrote: > I guess it's not possible to create a regression ...

6 years, 7 months ago (2014-05-16 13:02:00 UTC) #2

rune

Drop the empty "TEST=" from the description. https://codereview.chromium.org/282303007/diff/20001/LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html File LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html (right): https://codereview.chromium.org/282303007/diff/20001/LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html#newcode31 LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html:31: </script> If ...

6 years, 7 months ago (2014-05-16 22:20:09 UTC) #3

andersr

https://codereview.chromium.org/282303007/diff/20001/LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html File LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html (right): https://codereview.chromium.org/282303007/diff/20001/LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html#newcode31 LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html:31: </script> > internals.runtimeFlags Ah, wasn't aware that it existed. ...

6 years, 7 months ago (2014-05-19 08:10:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/282303007/50001

6 years, 7 months ago (2014-05-19 08:23:16 UTC) #7

Message was sent while issue was closed.

Change committed as 174269

Expand Messages | Collapse Messages