Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 282303007: Don't pretend that text-decoration is a shorthand in computed style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 282303007: Don't pretend that text-decoration is a shorthand in computed style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Same as Patch Set 3, with --no-find-copies Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/stable/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration-expected.txt ('k') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index 0f1cd86a03cbcab16e06a043628a6e1bc1bb0cb1..adc8897590b5caa77217af1104d0c6a49ec0f7c3 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -2198,7 +2198,9 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValu

case CSSPropertyTextAlignLast:

return cssValuePool().createValue(style->textAlignLast());

case CSSPropertyTextDecoration:

- return valuesForShorthandProperty(textDecorationShorthand());

+ if (RuntimeEnabledFeatures::css3TextDecorationsEnabled())

+ return valuesForShorthandProperty(textDecorationShorthand());

+ // Fall through.

case CSSPropertyTextDecorationLine:

return renderTextDecorationFlagsToCSSValue(style->textDecoration());

case CSSPropertyTextDecorationStyle: