LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html - Issue 282303007: Don't pretend that text-decoration is a shorthand in computed style.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration.html

Issue 282303007: Don't pretend that text-decoration is a shorthand in computed style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add test for stable/experimental. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <p>Test that computed style for text-decoration is correctly represented.</p>

	3 <div id="target" style="text-decoration: underline;">This text should be underli ned.</div>

	4 <pre id="result"></pre>

	5 <script>

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8

	9 function testDecoration(elm) {

	10 var decoration = getComputedStyle(elm).textDecoration;

	11

	12 // Checking the start of the result string is the best we can do here,

	13 // because we expect different results depending on whether experimental

	14 // features are enabled or not.

	15 //

	16 // The important thing is that the computed value for text-decoration

	17 // ends up in the text output somehow.

	18 var expectedStart = "underline";

	19 if (decoration.substr(0, expectedStart.length) != expectedStart)

	20 throw "Incorrect computed style: " + decoration + ". " +

	21 "Expected something that starts with: " + expectedStart;

	22

	23 return decoration;

	24 }

	25

	26 try {

	27 result.innerText = "PASS: " + testDecoration(target);

	28 } catch (e) {

	29 result.innerText = "FAIL: " + e;

	30 }

	31 </script>
	rune 2014/05/16 22:20:09 If you use js-test.js, you could do something like If you use js-test.js, you could do something like this which is more compact and checks more accurately: <!DOCTYPE html> <script src=".../resources/js-test.js"></script> <div id="target" ... </div> <script> description("Test that computed style for text-decoration is correctly represented."); var decoration = getComputedStyle(target).textDecoration; if (internals && internals.runtimeFlags.css3TextDecorations) shouldBe("decoration", "'underline solid rgb(0, 0, 0)'"); else shouldBe("decoration", "'underline'"); </script> andersr 2014/05/19 08:10:18 Ah, wasn't aware that it existed. Done! Show quoted text > internals.runtimeFlags Ah, wasn't aware that it existed. Done!
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css3-text/css3-text-decoration/stable/getComputedStyle-text-decoration-expected.txt » ('j') | no next file with comments »