third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp

index 00833ae3a5e4036f355ae0fa3f2704984b0a1ab8..55a61e253f73fc8a58c16ac185aef25b57ce25c7 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp

@@ -48,7 +48,6 @@ namespace blink {

#define EXPECT_OPAQUE_PIXELS_IN_RECT(bitmap, opaqueRect) \

{ \

- SkAutoLockPixels locker(bitmap); \

for (int y = opaqueRect.Y(); y < opaqueRect.MaxY(); ++y) \

for (int x = opaqueRect.X(); x < opaqueRect.MaxX(); ++x) { \

int alpha = *bitmap.getAddr32(x, y) >> 24; \

@@ -58,7 +57,6 @@ namespace blink {

#define EXPECT_OPAQUE_PIXELS_ONLY_IN_RECT(bitmap, opaqueRect) \

{ \

- SkAutoLockPixels locker(bitmap); \

for (int y = 0; y < bitmap.height(); ++y) \

for (int x = 0; x < bitmap.width(); ++x) { \

int alpha = *bitmap.getAddr32(x, y) >> 24; \