third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/DragImageTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

index 74a77c008f073020a1e0a33365e93968ca1a68dd..f10da2779f5a2e2bf7fbd701add5444cef2292f4 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

@@ -172,8 +172,6 @@ TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) {

canvas_->drawPicture(record);

EXPECT_EQ(0, decode_request_count_);

- SkAutoLockPixels auto_lock(bitmap_);

EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));

}

@@ -203,8 +201,6 @@ TEST_F(DeferredImageDecoderTest, drawIntoPaintRecordProgressive) {

PaintImage::CompletionState::DONE),

0, 0);

canvas_->drawPicture(recorder.finishRecordingAsPicture());

- SkAutoLockPixels auto_lock(bitmap_);

EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));

}

@@ -237,8 +233,6 @@ TEST_F(DeferredImageDecoderTest, decodeOnOtherThread) {

record));

thread.reset();

EXPECT_EQ(0, decode_request_count_);

- SkAutoLockPixels auto_lock(bitmap_);

EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));

}