Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
index de81bab9ae9e2ed7f3da423d2a5e9e3bb3e64ca6..a971f8a85bd911d9c770c78f5c8a0c77cb547d18 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
@@ -1244,8 +1244,6 @@ void GraphicsLayer::CheckPaintUnderInvalidations(
canvas.drawPicture(std::move(new_record));
}
- old_bitmap.lockPixels();
- new_bitmap.lockPixels();
int mismatching_pixels = 0;
static const int kMaxMismatchesToReport = 50;
for (int bitmap_y = 0; bitmap_y < rect.Height(); ++bitmap_y) {
@@ -1277,8 +1275,6 @@ void GraphicsLayer::CheckPaintUnderInvalidations(
}
}
}
- old_bitmap.unlockPixels();
- new_bitmap.unlockPixels();
// Visualize under-invalidations by overlaying the new bitmap (containing red
// pixels indicating under-invalidations, and transparent pixels otherwise)

Powered by Google App Engine
This is Rietveld 408576698