content/renderer/pepper/pepper_graphics_2d_host.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_graphics_2d_host.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_graphics_2d_host.cc

diff --git a/content/renderer/pepper/pepper_graphics_2d_host.cc b/content/renderer/pepper/pepper_graphics_2d_host.cc

index c2f625fac552fde1e2e33e880c65ffe6b23d2c01..6b6959ecf196bef5702bb1f6b5323ebc59360de6 100644

--- a/content/renderer/pepper/pepper_graphics_2d_host.cc

+++ b/content/renderer/pepper/pepper_graphics_2d_host.cc

@@ -106,8 +106,6 @@ void ConvertImageData(PPB_ImageData_Impl* src_image,

SkBitmap src_bitmap(src_image->GetMappedBitmap());

SkBitmap dest_bitmap(dest_image->GetMappedBitmap());

- SkAutoLockPixels src_lock(src_bitmap);

- SkAutoLockPixels dest_lock(dest_bitmap);

if (src_rect.width() == src_image->width() &&

dest_rect.width() == dest_image->width()) {

// Fast path if the full frame can be converted at once.