content/renderer/pepper/pepper_video_source_host.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_video_source_host.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_video_source_host.cc

diff --git a/content/renderer/pepper/pepper_video_source_host.cc b/content/renderer/pepper/pepper_video_source_host.cc

index 0a14c03fd1eda3798fe0be66971477541feda0d0..0e564b3b5207e7815abd10b1d9d76ca9a542ec6c 100644

--- a/content/renderer/pepper/pepper_video_source_host.cc

+++ b/content/renderer/pepper/pepper_video_source_host.cc

@@ -221,7 +221,6 @@ void PepperVideoSourceHost::SendGetFrameReply() {

return;

}

- SkAutoLockPixels lock(bitmap);

uint8_t* bitmap_pixels = static_cast<uint8_t*>(bitmap.getPixels());

if (!bitmap_pixels) {

SendGetFrameErrorReply(PP_ERROR_FAILED);