content/renderer/media/pepper_to_video_track_adapter.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/pepper_to_video_track_adapter.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/pepper_to_video_track_adapter.cc

diff --git a/content/renderer/media/pepper_to_video_track_adapter.cc b/content/renderer/media/pepper_to_video_track_adapter.cc

index c1f31cf381ebed5aceca3c5b1708edf041e7c959..7893276ed39633eaf432b91e19ef84c3a50b0067 100644

--- a/content/renderer/media/pepper_to_video_track_adapter.cc

+++ b/content/renderer/media/pepper_to_video_track_adapter.cc

@@ -168,7 +168,6 @@ void PpFrameWriter::PutFrame(PPB_ImageData_Impl* image_data,

return;

}

- SkAutoLockPixels src_lock(bitmap);

const uint8_t* src_data = static_cast<uint8_t*>(bitmap.getPixels());

const int src_stride = static_cast<int>(bitmap.rowBytes());

const int width = bitmap.width();