Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: components/display_compositor/gl_helper_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/display_compositor/gl_helper_unittest.cc
diff --git a/components/display_compositor/gl_helper_unittest.cc b/components/display_compositor/gl_helper_unittest.cc
index 73a837dfd0e2f28a549e7cadd12b1ee6813f0617..0cc4c73f95047d368a322adda3b725499f1d1a96 100644
--- a/components/display_compositor/gl_helper_unittest.cc
+++ b/components/display_compositor/gl_helper_unittest.cc
@@ -736,7 +736,6 @@ class GLHelperTest : public testing::Test {
}
// Now compare the results.
- SkAutoLockPixels lock_input(truth_pixels);
const std::vector<GLHelperScaling::ScalerStage> dummy_stages;
Compare(&truth_pixels, &output_pixels, 2, input_pixels.get(), dummy_stages,
message + " comparing against transformed/scaled");
@@ -961,8 +960,6 @@ class GLHelperTest : public testing::Test {
if (bmp1.colorType() != bmp2.colorType())
return false;
- SkAutoLockPixels lock1(bmp1);
- SkAutoLockPixels lock2(bmp2);
if (!bmp1.getPixels() || !bmp2.getPixels()) {
LOG(ERROR) << "Empty Bitmap!";
return false;
« no previous file with comments | « chrome/renderer/chrome_render_frame_observer.cc ('k') | components/favicon_base/select_favicon_frames_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698