chrome/renderer/chrome_render_frame_observer.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_frame_observer.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_frame_observer.cc

diff --git a/chrome/renderer/chrome_render_frame_observer.cc b/chrome/renderer/chrome_render_frame_observer.cc

index 366b3941cd7b7fc5ef447aaebfdc8804fd189d2e..5fbbb79a179957dc163f7dd7879862023508470e 100644

--- a/chrome/renderer/chrome_render_frame_observer.cc

+++ b/chrome/renderer/chrome_render_frame_observer.cc

@@ -209,7 +209,6 @@ void ChromeRenderFrameObserver::RequestThumbnailForContextNode(

thumbnail.copyTo(&bitmap, kN32_SkColorType);

std::vector<uint8_t> thumbnail_data;

- SkAutoLockPixels lock(bitmap);

if (bitmap.getPixels()) {

const int kDefaultQuality = 90;

std::vector<unsigned char> data;