components/favicon_base/select_favicon_frames_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base/select_favicon_frames_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon_base/select_favicon_frames_unittest.cc

diff --git a/components/favicon_base/select_favicon_frames_unittest.cc b/components/favicon_base/select_favicon_frames_unittest.cc

index 4fe404459c1840dee3eb171cc4501030c7c09131..f2a6f542754d8e56affaec707a01bd344f98c7b7 100644

--- a/components/favicon_base/select_favicon_frames_unittest.cc

+++ b/components/favicon_base/select_favicon_frames_unittest.cc

@@ -59,9 +59,7 @@ SkColor GetColor(const gfx::ImageSkia& image, float scale,

x = bitmap.width() / 2;

if (y == -1)

y = bitmap.width() / 2;

- bitmap.lockPixels();

SkColor color = bitmap.getColor(x, y);

- bitmap.unlockPixels();

return color;

}