chrome/browser/plugins/plugin_power_saver_browsertest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_power_saver_browsertest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugins/plugin_power_saver_browsertest.cc

diff --git a/chrome/browser/plugins/plugin_power_saver_browsertest.cc b/chrome/browser/plugins/plugin_power_saver_browsertest.cc

index 5f98efcb66db10c686c9e4ffb8de92ffe5bae40a..61e5130755f31427329856bee6854c3b106f35d2 100644

--- a/chrome/browser/plugins/plugin_power_saver_browsertest.cc

+++ b/chrome/browser/plugins/plugin_power_saver_browsertest.cc

@@ -184,7 +184,6 @@ bool SnapshotMatches(const base::FilePath& reference, const SkBitmap& bitmap) {

return false;

int32_t* ref_pixels = reinterpret_cast<int32_t*>(decoded.data());

- SkAutoLockPixels lock_image(bitmap);

int32_t* pixels = static_cast<int32_t*>(bitmap.getPixels());

bool success = true;