chrome/browser/sync/test/integration/bookmarks_helper.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/test/integration/bookmarks_helper.cc

diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc

index 2bf99e1fd4b4cdaf2e7826e0d8892cee6c2f3e5f..da2ab1c139a709a3cc71509beb0699a577dbb0ad 100644

--- a/chrome/browser/sync/test/integration/bookmarks_helper.cc

+++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc

@@ -190,8 +190,6 @@ bool FaviconRawBitmapsMatch(const SkBitmap& bitmap_a,

<< bitmap_b.height() << ")";

return false;

}

- SkAutoLockPixels bitmap_lock_a(bitmap_a);

- SkAutoLockPixels bitmap_lock_b(bitmap_b);

void* node_pixel_addr_a = bitmap_a.getPixels();

EXPECT_TRUE(node_pixel_addr_a);

void* node_pixel_addr_b = bitmap_b.getPixels();