chrome/browser/media/webrtc/window_icon_util_x11.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/window_icon_util_x11.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/window_icon_util_x11.cc

diff --git a/chrome/browser/media/webrtc/window_icon_util_x11.cc b/chrome/browser/media/webrtc/window_icon_util_x11.cc

index c316c948b405cddbd5e9ae5ff5755ec20900f5b1..a69c365d7b770873d5e13a85778e2b7f180ce2a9 100644

--- a/chrome/browser/media/webrtc/window_icon_util_x11.cc

+++ b/chrome/browser/media/webrtc/window_icon_util_x11.cc

@@ -59,7 +59,6 @@ gfx::ImageSkia GetWindowIcon(content::DesktopMediaID id) {

SkBitmap result;

SkImageInfo info = SkImageInfo::MakeN32(width, height, kUnpremul_SkAlphaType);

result.allocPixels(info);

- result.lockPixels();

uint32_t* pixels_data = reinterpret_cast<uint32_t*>(result.getPixels());