Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/media/webrtc/native_desktop_media_list.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/native_desktop_media_list.cc
diff --git a/chrome/browser/media/webrtc/native_desktop_media_list.cc b/chrome/browser/media/webrtc/native_desktop_media_list.cc
index d6039e15a0bcd2d49a4d18ee8c483139f2138959..70c4eb519e1c85829de71a372fef871284a71063 100644
--- a/chrome/browser/media/webrtc/native_desktop_media_list.cc
+++ b/chrome/browser/media/webrtc/native_desktop_media_list.cc
@@ -54,7 +54,6 @@ gfx::ImageSkia ScaleDesktopFrame(std::unique_ptr<webrtc::DesktopFrame> frame,
SkBitmap result;
result.allocN32Pixels(scaled_rect.width(), scaled_rect.height(), true);
- result.lockPixels();
uint8_t* pixels_data = reinterpret_cast<uint8_t*>(result.getPixels());
libyuv::ARGBScale(frame->data(), frame->stride(),
@@ -75,8 +74,6 @@ gfx::ImageSkia ScaleDesktopFrame(std::unique_ptr<webrtc::DesktopFrame> frame,
}
}
- result.unlockPixels();
-
return gfx::ImageSkia::CreateFrom1xBitmap(result);
}
« no previous file with comments | « chrome/browser/media/webrtc/desktop_media_list_base.cc ('k') | chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698