Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2070)

Unified Diff: chrome/browser/media/webrtc/desktop_media_list_base.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/desktop_media_list_base.cc
diff --git a/chrome/browser/media/webrtc/desktop_media_list_base.cc b/chrome/browser/media/webrtc/desktop_media_list_base.cc
index 33f560ffe87042a4a6e60becebfac69b050f4c7a..2f700d3ad31361f16c3a502c96909015bddecfde 100644
--- a/chrome/browser/media/webrtc/desktop_media_list_base.cc
+++ b/chrome/browser/media/webrtc/desktop_media_list_base.cc
@@ -137,10 +137,7 @@ void DesktopMediaListBase::ScheduleNextRefresh() {
// static
uint32_t DesktopMediaListBase::GetImageHash(const gfx::Image& image) {
SkBitmap bitmap = image.AsBitmap();
- bitmap.lockPixels();
uint32_t value =
base::Hash(reinterpret_cast<char*>(bitmap.getPixels()), bitmap.getSize());
- bitmap.unlockPixels();
-
return value;
}

Powered by Google App Engine
This is Rietveld 408576698