Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
diff --git a/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc b/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
index 3ad2de008be52993907caee1515a129a62d5406f..183441a82879ddad15217ca6bafd1e2daef6e7ee 100644
--- a/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
+++ b/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
@@ -62,7 +62,6 @@ gfx::Image CreateGrayscaleImage(gfx::Size size, uint8_t greyscale_value) {
SkBitmap result;
result.allocN32Pixels(size.width(), size.height(), true);
- result.lockPixels();
uint8_t* pixels_data = reinterpret_cast<uint8_t*>(result.getPixels());
// Set greyscale value for all pixels.
@@ -79,8 +78,6 @@ gfx::Image CreateGrayscaleImage(gfx::Size size, uint8_t greyscale_value) {
}
}
- result.unlockPixels();
-
return gfx::Image::CreateFrom1xBitmap(result);
}
« no previous file with comments | « chrome/browser/media/webrtc/native_desktop_media_list.cc ('k') | chrome/browser/media/webrtc/window_icon_util_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698