chrome/browser/extensions/extension_action_storage_manager.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_storage_manager.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action_storage_manager.cc

diff --git a/chrome/browser/extensions/extension_action_storage_manager.cc b/chrome/browser/extensions/extension_action_storage_manager.cc

index a00a595189641963441ed2daa1a372456fde18a1..61c83f9a6bca9f7fdbb7621fa0c01404f7b53be5 100644

--- a/chrome/browser/extensions/extension_action_storage_manager.cc

+++ b/chrome/browser/extensions/extension_action_storage_manager.cc

@@ -80,7 +80,6 @@ bool StringToSkBitmap(const std::string& str, SkBitmap* bitmap) {

// Conversion function for reading/writing to storage.

std::string BitmapToString(const SkBitmap& bitmap) {

- SkAutoLockPixels lock_image(bitmap);

std::vector<unsigned char> data;

bool success = gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, false, &data);

if (!success)