chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc ('k') | chrome/browser/devtools/devtools_eye_dropper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

index 574f5380de1c14e48a9201346a78537080f148ef..72b3b4e528f496035a86de9a88a31af565697fa2 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc

@@ -124,7 +124,6 @@ scoped_refptr<base::RefCountedBytes> GenerateTestPNG(const int& width,

for (int x = 0; x < width; ++x)

*bmp.getAddr32(x, y) = background_color;

}

- SkAutoLockPixels lock(bmp);

scoped_refptr<base::RefCountedBytes> png_bytes(new base::RefCountedBytes());

gfx::PNGCodec::ColorFormat color_format = gfx::PNGCodec::FORMAT_RGBA;

if (!gfx::PNGCodec::Encode(