chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

diff --git a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

index 6015a69e3fca3a4d06c8d2d9cf3d362d44e96a9c..83d0e0980d07017562e107d4976f51b1df03fbdb 100644

--- a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

+++ b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

@@ -137,10 +137,8 @@ bool ImageIsNearColor(gfx::ImageSkia image, SkColor expected_color) {

return false;

}

- bitmap->lockPixels();

gfx::Point center = gfx::Rect(image.size()).CenterPoint();

SkColor image_color = bitmap->getColor(center.x(), center.y());

- bitmap->unlockPixels();

const int kDiff = 3;

if (std::abs(static_cast<int>(SkColorGetA(image_color)) -