chrome/browser/devtools/devtools_eye_dropper.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_eye_dropper.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_eye_dropper.cc

diff --git a/chrome/browser/devtools/devtools_eye_dropper.cc b/chrome/browser/devtools/devtools_eye_dropper.cc

index ca08c13d1f3d9de04192534512df929cd5df0289..bb38173b238039ef5f848f0a6c914dc224cc19fd 100644

--- a/chrome/browser/devtools/devtools_eye_dropper.cc

+++ b/chrome/browser/devtools/devtools_eye_dropper.cc

@@ -126,7 +126,6 @@ bool DevToolsEyeDropper::HandleMouseEvent(const blink::WebMouseEvent& event) {

return true;

}

- SkAutoLockPixels lock_image(frame_);

SkColor sk_color = frame_.getColor(last_cursor_x_, last_cursor_y_);

callback_.Run(SkColorGetR(sk_color), SkColorGetG(sk_color),

SkColorGetB(sk_color), SkColorGetA(sk_color));