Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2822933004: [ObjC ARC] Converts ios/chrome/browser/ui/dialogs:dialogs_internal to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/dialogs:dialogs_internal to ARC. Automatically generated ARCMigrate commit Notable issues:Keep the scoped_nsobject in _dialogCoordinatorsForWebStates BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2822933004 Cr-Commit-Position: refs/heads/master@{#465514} Committed: https://chromium.googlesource.com/chromium/src/+/e5fad2002f2a4b5a47b2ad900509176dbfb03dbb

Patch Set 1 #

Patch Set 2 : Remove presentedDialogWebState ivar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -90 lines) Patch
M ios/chrome/browser/ui/dialogs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/dialogs/dialog_presenter.mm View 1 15 chunks +51 lines, -88 lines 0 comments Download
M ios/chrome/browser/ui/dialogs/java_script_dialog_presenter_impl.mm View 1 chunk +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-18 09:43:10 UTC) #7
kkhorimoto
lgtm
3 years, 8 months ago (2017-04-18 17:45:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822933004/20001
3 years, 8 months ago (2017-04-19 06:46:38 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 06:50:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5fad2002f2a4b5a47b2ad900509...

Powered by Google App Engine
This is Rietveld 408576698