Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2822933002: Fix the settings button and UMA metrics for the message center (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix the settings button and UMA metrics for the message center The settings button was unintentionally broken for Windows and Linux users in 2799653004, as was gathering of some UMA. This CL offers a slight refactoring that meets all goals. BUG=706658 Review-Url: https://codereview.chromium.org/2807623002 Cr-Commit-Position: refs/heads/master@{#463339} (cherry picked from commit 9b6e3c78898f12a0183edffb62d189cb716c6135) Review-Url: https://codereview.chromium.org/2822933002 . Cr-Commit-Position: refs/branch-heads/3029@{#729} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/47650b27b22ddf35a1abed716c82c4d8248ce1f8

Patch Set 1 #

Patch Set 2 : Fix the settings button and UMA metrics for the message center #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M chrome/browser/notifications/message_center_stats_collector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_stats_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/web_notification_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/web_notification_delegate.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/message_center/message_center_observer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/message_center/message_center_tray.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/message_center_tray.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/message_center/notification_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/message_center/notification_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (5 generated)
yhanada
3 years, 8 months ago (2017-04-17 02:21:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47650b27b22ddf35a1abed716c82c4d8248ce1f8.

Powered by Google App Engine
This is Rietveld 408576698