Fix test slowness introduced by https://codereview.chromium.org/2771793003

Fix test slowness introduced by https://codereview.chromium.org/2771793003

https://codereview.chromium.org/2771793003 moved the the timer for downloading
an icon from webapk_installer.cc to webapk_icon_hasher.cc The CL did not
provide a way of making the timeout shorter similar to
WebApkInstaller::SetTimeoutMs(). This was causing
WebApkInstallerTest.BestPrimaryIconUrlDownloadTimesOut and
WebApkInstallerTest.BestBadgeIconUrlDownloadTimesOut to take over a minute each.

This CL:
- Introduces a new static method
WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout() which takes a
custom timeout.
- Removes the tests about the icon download timing out from
webapk_installer_unittest.cc since this scenario is already tested in
webapk_icon_hasher_unittest.cc

Review-Url: https://codereview.chromium.org/2822883002
Cr-Commit-Position: refs/heads/master@{#465750}
Committed: https://chromium.googlesource.com/chromium/src/+/e7c580f5192add33af200317f7097b2b1b3d4910

[pkotwicz, 2017-04-15 01:46:46]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-04-15 01:46:47]

Xi, can you please take a look?

[Xi Han, 2017-04-18 15:38:10]

lgtm

[pkotwicz, 2017-04-18 18:45:35]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-04-18 18:45:36]

Dominick, can you please take a look?

[dominickn, 2017-04-19 00:04:08]

lgtm % nit

https://codereview.chromium.org/2822883002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_icon_hasher.cc (right):

https://codereview.chromium.org/2822883002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_icon_hasher.cc:48: void
WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout(
Nit: I would call this DownloadAndComputeMurmur2HashForTesting, since this is
intended as a test-only method and prod code should always call the other
version.

[pkotwicz, 2017-04-19 20:34:53]

https://codereview.chromium.org/2822883002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_icon_hasher.cc (right):

https://codereview.chromium.org/2822883002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_icon_hasher.cc:48: void
WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout(
I don't thinkat that DownloadAndComputeMurmur2HashForTesting() is a good name.

Prod should not call this function directly. However, the prod version of the
function calls this function

[pkotwicz, 2017-04-19 20:34:56]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-04-19 20:35:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:17:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492634096817280, "parent_rev":
"e8e89d55e8f02315056a6c524f8fff83fbe1b289", "commit_rev":
"e7c580f5192add33af200317f7097b2b1b3d4910"}

[commit-bot: I haz the power, 2017-04-19 21:17:44]

Description was changed from

==========
Fix test slowness introduced by https://codereview.chromium.org/2771793003

https://codereview.chromium.org/2771793003 moved the the timer for downloading
an icon from webapk_installer.cc to webapk_icon_hasher.cc The CL did not
provide a way of making the timeout shorter similar to
WebApkInstaller::SetTimeoutMs(). This was causing
WebApkInstallerTest.BestPrimaryIconUrlDownloadTimesOut and
WebApkInstallerTest.BestBadgeIconUrlDownloadTimesOut to take over a minute each.

This CL:
- Introduces a new static method
WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout() which takes a
custom timeout.
- Removes the tests about the icon download timing out from
webapk_installer_unittest.cc since this scenario is already tested in
webapk_icon_hasher_unittest.cc
==========

to

==========
Fix test slowness introduced by https://codereview.chromium.org/2771793003

https://codereview.chromium.org/2771793003 moved the the timer for downloading
an icon from webapk_installer.cc to webapk_icon_hasher.cc The CL did not
provide a way of making the timeout shorter similar to
WebApkInstaller::SetTimeoutMs(). This was causing
WebApkInstallerTest.BestPrimaryIconUrlDownloadTimesOut and
WebApkInstallerTest.BestBadgeIconUrlDownloadTimesOut to take over a minute each.

This CL:
- Introduces a new static method
WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout() which takes a
custom timeout.
- Removes the tests about the icon download timing out from
webapk_installer_unittest.cc since this scenario is already tested in
webapk_icon_hasher_unittest.cc

Review-Url: https://codereview.chromium.org/2822883002
Cr-Commit-Position: refs/heads/master@{#465750}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7c580f5192add33af200317f709...
==========

[commit-bot: I haz the power, 2017-04-19 21:17:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7c580f5192add33af200317f709...