chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc - Issue 2822883002: Fix test slowness introduced by https://codereview.chromium.org/2771793003

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc

Issue 2822883002: Fix test slowness introduced by https://codereview.chromium.org/2771793003 (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc

diff --git a/chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc b/chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc

index c23d51d90bf0983c7d12a73badbc0607e9ce2a71..c96f86a2dfe92f5fd8a94f3ba04bdf892146cc68 100644

--- a/chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc

+++ b/chrome/browser/android/webapk/webapk_icon_hasher_unittest.cc

@@ -37,8 +37,8 @@ class WebApkIconHasherRunner {

~WebApkIconHasherRunner() {}

void Run(const GURL& icon_url) {

- WebApkIconHasher::DownloadAndComputeMurmur2Hash(

- url_request_context_getter_.get(), icon_url,

+ WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout(

+ url_request_context_getter_.get(), icon_url, 100,

base::Bind(&WebApkIconHasherRunner::OnCompleted,

base::Unretained(this)));