Remove usage of Tab's |url| property from MainController.

Remove usage of Tab's |url| property from MainController.

BUG=546208
Review-Url: https://codereview.chromium.org/2822753002
Cr-Commit-Position: refs/heads/master@{#476170}
Committed: https://chromium.googlesource.com/chromium/src/+/8ca1ef5c7a9c42b350aa978c0ec7d735d8aca5ac

[kkhorimoto, 2017-04-14 20:27:22]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org, sdefresne@chromium.org

[kkhorimoto, 2017-04-14 20:27:23]

https://codereview.chromium.org/2822753002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2822753002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2234: if (!(currentTabInTargetBVC &&
IsURLNtp(currentTabInTargetBVC.visibleURL))) {
We want to return the current Tab if no navigations have occurred.  If there's a
user-initiated load on an NTP, we would want to create a new Tab, so using
visible URL here.

[Eugene But (OOO till 7-30), 2017-04-14 21:38:36]

https://codereview.chromium.org/2822753002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2822753002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2234: if (!(currentTabInTargetBVC &&
IsURLNtp(currentTabInTargetBVC.visibleURL))) {
On 2017/04/14 20:27:23, kkhorimoto_ wrote:
> We want to return the current Tab if no navigations have occurred.  If there's
a
> user-initiated load on an NTP, we would want to create a new Tab, so using
> visible URL here.
But NTP can not be pending, or transient, right? If so, then lastCommittedURL
should work here, I guess....

[kkhorimoto, 2017-05-31 23:02:08]

https://codereview.chromium.org/2822753002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2822753002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2234: if (!(currentTabInTargetBVC &&
IsURLNtp(currentTabInTargetBVC.visibleURL))) {
On 2017/04/14 21:38:36, Eugene But wrote:
> On 2017/04/14 20:27:23, kkhorimoto_ wrote:
> > We want to return the current Tab if no navigations have occurred.  If
there's
> a
> > user-initiated load on an NTP, we would want to create a new Tab, so using
> > visible URL here.
> But NTP can not be pending, or transient, right? If so, then lastCommittedURL
> should work here, I guess....

If the visible URL is not the NTP URL, that means that the NTP has been replaced
by the webview.  The intention of this code is to open the url in the current
tab only if it's displaying the NTP, which will only be true if the visible URL
is the NTP.

[Eugene But (OOO till 7-30), 2017-05-31 23:44:30]

lgtm

[kkhorimoto, 2017-06-01 03:16:28]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-01 03:16:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 03:27:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496286988630970, "parent_rev":
"17c57e62c598b8c3604ed66f277b65c04b13eea8", "commit_rev":
"8ca1ef5c7a9c42b350aa978c0ec7d735d8aca5ac"}

[commit-bot: I haz the power, 2017-06-01 03:27:37]

Description was changed from

==========
Remove usage of Tab's |url| property from MainController.

BUG=546208
==========

to

==========
Remove usage of Tab's |url| property from MainController.

BUG=546208

Review-Url: https://codereview.chromium.org/2822753002
Cr-Commit-Position: refs/heads/master@{#476170}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ca1ef5c7a9c42b350aa978c0ec7...
==========

[commit-bot: I haz the power, 2017-06-01 03:27:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ca1ef5c7a9c42b350aa978c0ec7...