Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2817253002: Added |lastCommittedURL| and |visibleURL| to Tab's interface. (Closed)

Created:
3 years, 8 months ago by kkhorimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added |lastCommittedURL| and |visibleURL| to Tab's interface. Eventually, all callers to existing |url| property will be updated to call these properties. BUG=546208 Review-Url: https://codereview.chromium.org/2817253002 Cr-Commit-Position: refs/heads/master@{#464817} Committed: https://chromium.googlesource.com/chromium/src/+/1f0a73dc2c3b3622658619fec05205797c647e01

Patch Set 1 #

Total comments: 2

Patch Set 2 : returns => Returns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M ios/chrome/browser/tabs/tab.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kkhorimoto
3 years, 8 months ago (2017-04-14 18:39:25 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2817253002/diff/1/ios/chrome/browser/tabs/tab.h File ios/chrome/browser/tabs/tab.h (right): https://codereview.chromium.org/2817253002/diff/1/ios/chrome/browser/tabs/tab.h#newcode112 ios/chrome/browser/tabs/tab.h:112: // returns the URL of the visible NavigationItem ...
3 years, 8 months ago (2017-04-14 18:55:00 UTC) #3
kkhorimoto
returns => Returns
3 years, 8 months ago (2017-04-14 23:02:01 UTC) #4
kkhorimoto
https://codereview.chromium.org/2817253002/diff/1/ios/chrome/browser/tabs/tab.h File ios/chrome/browser/tabs/tab.h (right): https://codereview.chromium.org/2817253002/diff/1/ios/chrome/browser/tabs/tab.h#newcode112 ios/chrome/browser/tabs/tab.h:112: // returns the URL of the visible NavigationItem for ...
3 years, 8 months ago (2017-04-14 23:02:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817253002/20001
3 years, 8 months ago (2017-04-14 23:02:43 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 23:15:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f0a73dc2c3b3622658619fec052...

Powered by Google App Engine
This is Rietveld 408576698