Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2822543006: Start reporting watch time if ABR adapts above 200p. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Start reporting watch time if ABR adapts above 200p. Previously we only checked the initial resolution and assumed it was always large enough to start watch time reporting; clearly this is not true since YouTube offers a 140p format. Probably we also want to drop the minimum resolution to 200x140p, which I'll check with product about and handle in a followup CL. BUG=711792 TEST=new tests. Manual: force 140p, adapt above, verify watch time. Review-Url: https://codereview.chromium.org/2822543006 Cr-Commit-Position: refs/heads/master@{#464826} Committed: https://chromium.googlesource.com/chromium/src/+/2540556a43a467a11d4c2cffdb9457b97d8b94c4

Patch Set 1 #

Patch Set 2 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M media/blink/watch_time_reporter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/watch_time_reporter.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M media/blink/watch_time_reporter_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
DaleCurtis
3 years, 8 months ago (2017-04-14 21:58:22 UTC) #2
sandersd (OOO until July 31)
lgtm
3 years, 8 months ago (2017-04-14 22:07:50 UTC) #3
DaleCurtis
Thanks for review! Simplified the logic a bit.
3 years, 8 months ago (2017-04-14 22:12:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822543006/20001
3 years, 8 months ago (2017-04-14 22:13:09 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 23:36:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2540556a43a467a11d4c2cffdb94...

Powered by Google App Engine
This is Rietveld 408576698