Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: media/blink/watch_time_reporter_unittest.cc

Issue 2822543006: Start reporting watch time if ABR adapts above 200p. (Closed)
Patch Set: Simplify Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/watch_time_reporter.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/watch_time_reporter_unittest.cc
diff --git a/media/blink/watch_time_reporter_unittest.cc b/media/blink/watch_time_reporter_unittest.cc
index 3bdad7a253285b5838ce27a31cd0311c101267e3..2aa2635a047d4a5e6e6f236b4663251115f6457a 100644
--- a/media/blink/watch_time_reporter_unittest.cc
+++ b/media/blink/watch_time_reporter_unittest.cc
@@ -279,39 +279,48 @@ TEST_P(WatchTimeReporterTest, WatchTimeReporter) {
Initialize(!has_video_, true, true, gfx::Size());
wtr_->OnPlaying();
EXPECT_EQ(!has_video_, IsMonitoring());
+ EXPECT_FALSE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, true, true, gfx::Size());
wtr_->OnPlaying();
EXPECT_EQ(!has_video_, IsMonitoring());
+ EXPECT_FALSE(wtr_->IsSizeLargeEnoughToReportWatchTime());
constexpr gfx::Size kSizeTooSmall = gfx::Size(100, 100);
Initialize(!has_video_, true, true, kSizeTooSmall);
wtr_->OnPlaying();
EXPECT_EQ(!has_video_, IsMonitoring());
+ EXPECT_FALSE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, true, true, kSizeJustRight);
wtr_->OnPlaying();
EXPECT_TRUE(IsMonitoring());
+ EXPECT_TRUE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, false, false, kSizeJustRight);
wtr_->OnPlaying();
EXPECT_TRUE(IsMonitoring());
+ EXPECT_TRUE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, true, false, kSizeJustRight);
wtr_->OnPlaying();
EXPECT_TRUE(IsMonitoring());
+ EXPECT_TRUE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, true, true, gfx::Size());
wtr_->OnPlaying();
EXPECT_EQ(!has_video_, IsMonitoring());
+ EXPECT_FALSE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, false, false, gfx::Size());
wtr_->OnPlaying();
EXPECT_EQ(!has_video_, IsMonitoring());
+ EXPECT_FALSE(wtr_->IsSizeLargeEnoughToReportWatchTime());
Initialize(true, true, false, gfx::Size());
wtr_->OnPlaying();
EXPECT_EQ(!has_video_, IsMonitoring());
+ EXPECT_FALSE(wtr_->IsSizeLargeEnoughToReportWatchTime());
if (!has_video_)
EXPECT_WATCH_TIME_FINALIZED();
« no previous file with comments | « media/blink/watch_time_reporter.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698