Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2822513002: Let DoMapBufferRange write the result integer to signal a GL error. (Closed)

Created:
3 years, 8 months ago by Geoff Lang
Modified:
3 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Let DoMapBufferRange write the result integer to signal a GL error. TEST=conformance2/buffers/get-buffer-sub-data BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2822513002 Cr-Commit-Position: refs/heads/master@{#464530} Committed: https://chromium.googlesource.com/chromium/src/+/eeeeb4f79e608105b47b1584084545c04c8c0c02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 3 chunks +4 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Geoff Lang
PTAL
3 years, 8 months ago (2017-04-13 17:46:08 UTC) #5
Zhenyao Mo
lgtm
3 years, 8 months ago (2017-04-13 18:37:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822513002/1
3 years, 8 months ago (2017-04-13 20:29:30 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 20:36:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eeeeb4f79e608105b47b15840845...

Powered by Google App Engine
This is Rietveld 408576698