Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc

Issue 2822513002: Let DoMapBufferRange write the result integer to signal a GL error. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
index a1398ed00face271b0ae54410cde388f2c2989b6..46b0f571b675c9d4edc1f46886a0e3baa0376080 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
@@ -1322,13 +1322,14 @@ error::Error GLES2DecoderPassthroughImpl::HandleMapBufferRange(
return error::kOutOfBounds;
}
- error::Error error = DoMapBufferRange(target, offset, size, access, mem,
- c.data_shm_id, c.data_shm_offset);
+ error::Error error =
+ DoMapBufferRange(target, offset, size, access, mem, c.data_shm_id,
+ c.data_shm_offset, result);
if (error != error::kNoError) {
+ DCHECK(*result == 0);
return error;
}
- *result = 1;
return error::kNoError;
}
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698