Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2822403002: Address minor comments on https://codereview.chromium.org/2816033002 (Closed)

Created:
3 years, 8 months ago by vasilii
Modified:
3 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M components/password_manager/core/browser/login_database_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/password_manager/core/browser/psl_matching_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
vasilii
Hi Vaclav, please review.
3 years, 8 months ago (2017-04-19 08:38:08 UTC) #2
vabr (Chromium)
LGTM, thanks for the follow-up! Vaclav
3 years, 8 months ago (2017-04-19 09:05:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822403002/1
3 years, 8 months ago (2017-04-19 09:13:10 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 10:16:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3ab8efcc3b78b2b5bf9dabdc94a...

Powered by Google App Engine
This is Rietveld 408576698