Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 2822403002: Address minor comments on https://codereview.chromium.org/2816033002 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/psl_matching_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc
index e04d1c25c32b281c5736fd0523a9cb2868afa25f..b15468f57bbbb4768c7fd2e107d07dfe461721b5 100644
--- a/components/password_manager/core/browser/login_database_unittest.cc
+++ b/components/password_manager/core/browser/login_database_unittest.cc
@@ -447,7 +447,7 @@ TEST_F(LoginDatabaseTest, TestFederatedMatchingLocalhost) {
EXPECT_EQ(AddChangeForForm(form), db().AddLogin(form));
EXPECT_EQ(AddChangeForForm(form_with_port), db().AddLogin(form_with_port));
- // Match twice.
+ // Match localhost with and without port.
PasswordStore::FormDigest form_request(PasswordForm::SCHEME_HTML,
"http://localhost/",
GURL("http://localhost/"));
@@ -455,7 +455,6 @@ TEST_F(LoginDatabaseTest, TestFederatedMatchingLocalhost) {
EXPECT_TRUE(db().GetLogins(form_request, &result));
EXPECT_THAT(result, UnorderedElementsAre(Pointee(form)));
- // Match against the mobile site.
form_request.origin = GURL("http://localhost:8080/");
form_request.signon_realm = "http://localhost:8080/";
EXPECT_TRUE(db().GetLogins(form_request, &result));
« no previous file with comments | « no previous file | components/password_manager/core/browser/psl_matching_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698