Remove SSLPrivateKey metadata hooks.

Remove SSLPrivateKey metadata hooks.

These are no longer needed; BoringSSL just extracts them from the
certificate itself. Some of the SSLPrivateKey implementations still need
this metadata and platform APIs are unreliable, so keep
GetClientCertInfo around for that. Though some of it can be extracted
from the signature type when we finally update to TLS 1.3.

BUG=none

Review-Url: https://codereview.chromium.org/2822283002
Cr-Commit-Position: refs/heads/master@{#465780}
Committed: https://chromium.googlesource.com/chromium/src/+/e422380770440c83c6365533055e563ce07dd1c3

[davidben, 2017-04-18 19:09:39]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 19:10:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:22:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[davidben, 2017-04-18 19:40:18]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 19:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:53:08]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[davidben, 2017-04-18 20:08:50]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 20:09:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 21:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:34:03]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-04-18 22:20:49]

davidben@chromium.org changed reviewers:
+ svaldez@chromium.org

[svaldez, 2017-04-19 17:34:56]

lgtm

[davidben, 2017-04-19 17:39:09]

davidben@chromium.org changed reviewers:
+ emaxx@chromium.org

[davidben, 2017-04-19 17:39:09]

+emaxx for certificate_provider bits.

[emaxx, 2017-04-19 19:39:23]

LGTM with a nit for certificate_provider

[emaxx, 2017-04-19 19:39:34]

https://codereview.chromium.org/2822283002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/certificate_provider/certificate_info.h (right):

https://codereview.chromium.org/2822283002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/certificate_provider/certificate_info.h:8: #include
<stddef.h>
nit: This is not used anymore.

[davidben, 2017-04-19 20:40:50]

https://codereview.chromium.org/2822283002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/certificate_provider/certificate_info.h (right):

https://codereview.chromium.org/2822283002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/certificate_provider/certificate_info.h:8: #include
<stddef.h>
On 2017/04/19 19:39:34, emaxx wrote:
> nit: This is not used anymore.

Done.

[davidben, 2017-04-19 20:41:31]

The CQ bit was checked by davidben@chromium.org

[davidben, 2017-04-19 20:41:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
svaldez@chromium.org, emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2822283002/#ps80001
(title: "emaxx comment")

[commit-bot: I haz the power, 2017-04-19 20:42:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:20:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492634491842830,
"parent_rev": "ae7d1d172a51548e0aad63f1ef051c53dca0903e", "commit_rev":
"e422380770440c83c6365533055e563ce07dd1c3"}

[commit-bot: I haz the power, 2017-04-19 22:20:14]

Description was changed from

==========
Remove SSLPrivateKey metadata hooks.

These are no longer needed; BoringSSL just extracts them from the
certificate itself. Some of the SSLPrivateKey implementations still need
this metadata and platform APIs are unreliable, so keep
GetClientCertInfo around for that. Though some of it can be extracted
from the signature type when we finally update to TLS 1.3.

BUG=none
==========

to

==========
Remove SSLPrivateKey metadata hooks.

These are no longer needed; BoringSSL just extracts them from the
certificate itself. Some of the SSLPrivateKey implementations still need
this metadata and platform APIs are unreliable, so keep
GetClientCertInfo around for that. Though some of it can be extracted
from the signature type when we finally update to TLS 1.3.

BUG=none

Review-Url: https://codereview.chromium.org/2822283002
Cr-Commit-Position: refs/heads/master@{#465780}
Committed:
https://chromium.googlesource.com/chromium/src/+/e422380770440c83c6365533055e...
==========

[commit-bot: I haz the power, 2017-04-19 22:20:16]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e422380770440c83c6365533055e...