chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc - Issue 2822283002: Remove SSLPrivateKey metadata hooks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

Issue 2822283002: Remove SSLPrivateKey metadata hooks. (Closed)

Patch Set: emaxx comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

index 917a7d88b37630f33f0695de4b8e52058320f88f..b324f2171dc36d6dfad2afe9a2f0ca9d95c835fb 100644

--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

@@ -140,12 +140,6 @@ bool CertificateProviderInternalReportCertificatesFunction::

switch (type) {

case net::X509Certificate::kPublicKeyTypeRSA:

- DCHECK(public_key_length_in_bits);

- // Convert bits to bytes.

- out_info->max_signature_length_in_bytes =

- (public_key_length_in_bits + 7) / 8;

- out_info->type = net::SSLPrivateKey::Type::RSA;

break;

case net::X509Certificate::kPublicKeyTypeECDSA:

WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_ERROR,