Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2822203004: [js-perf-tests] Add classes benchmarks from SixSpeed. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-tests] Add classes benchmarks from SixSpeed. In particular the Babel generated code for simple constructors is of interest here, since that's what we hit in the wild most often currently. BUG=v8:6275 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2822203004 Cr-Commit-Position: refs/heads/master@{#44719} Committed: https://chromium.googlesource.com/v8/v8/+/b161581947f6b37a181a45f182d20c269da8a54e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
M test/js-perf-test/SixSpeed.json View 1 chunk +25 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/classes/babel.js View 1 chunk +51 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/classes/es5.js View 1 chunk +20 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/classes/es6.js View 1 chunk +21 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-19 10:56:36 UTC) #1
Yang
On 2017/04/19 10:56:36, Benedikt Meurer wrote: rubberstamped lgtm.
3 years, 8 months ago (2017-04-19 10:57:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822203004/1
3 years, 8 months ago (2017-04-19 11:00:49 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 11:23:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b161581947f6b37a181a45f182d20c269da...

Powered by Google App Engine
This is Rietveld 408576698