Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2823403003: [WIP] Move JSOrdinaryHasInstance lowering to JSNativeContextSpecialization. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 5 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[WIP] Move JSOrdinaryHasInstance lowering to JSNativeContextSpecialization. Also ensure that a known constructor being used inside an instanceof get's a proper initial map on-demand. BUG=v8:6275

Patch Set 1 #

Patch Set 2 : Check for instance prototype. #

Patch Set 3 : [WIP] Constant-fold certain JSOrdinaryHasInstance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -154 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 2 2 chunks +214 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +3 lines, -152 lines 0 comments Download

Depends on Patchset:

Issue 2822203004 Patch 1

Messages

Total messages: 12 (12 generated)
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-19 11:38:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823403003/1
3 years, 8 months ago (2017-04-19 11:38:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 11:55:52 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/20561) v8_linux64_avx2_rel_ng_triggered on ...
3 years, 8 months ago (2017-04-19 11:55:52 UTC) #4
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-19 12:14:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823403003/20001
3 years, 8 months ago (2017-04-19 12:14:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 12:40:22 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-19 12:40:24 UTC) #8
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-19 12:49:45 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823403003/40001
3 years, 8 months ago (2017-04-19 12:49:52 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 13:13:43 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 13:13:44 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698