Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2822183002: Fetch, XHR: Use ", " as header list value separator. (Closed)

Created:
3 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, gavinp+loader_chromium.org, haraken, Nate Chapin, kinuko+watch, loading-reviews+fetch_chromium.org, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch, XHR: Use ", " as header list value separator. Adapt to https://github.com/whatwg/fetch/pull/504 and https://github.com/whatwg/xhr/pull/130, which started requiring combined header list values to be separated by ", " instead of just ",". The XHR code handling responses already did that, but |ResourceRequest| and |FetchHeaderList| both had to be updated. As a bonus, this also makes us pass w-p-t's headers-combine.html. BUG=700434, 705490 R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2822183002 Cr-Commit-Position: refs/heads/master@{#465537} Committed: https://chromium.googlesource.com/chromium/src/+/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
Raphael Kubo da Costa (rakuco)
PTAL
3 years, 8 months ago (2017-04-18 14:44:14 UTC) #5
Mike West
lgtm
3 years, 8 months ago (2017-04-19 08:30:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822183002/1
3 years, 8 months ago (2017-04-19 08:54:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933
3 years, 8 months ago (2017-04-19 08:59:08 UTC) #13
tyoshino (SeeGerritForStatus)
3 years, 8 months ago (2017-04-20 08:40:31 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698