third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp - Issue 2822183002: Fetch, XHR: Use ", " as header list value separator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

Issue 2822183002: Fetch, XHR: Use ", " as header list value separator. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp b/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

index 4ef2381c3df2d06dc85394ea3898fd9f1b970bb4..42111cf56695e77fc51d7afac255f2dcb7e7d4f3 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

@@ -99,8 +99,7 @@ bool FetchHeaderList::Get(const String& name, String& result) const {

resultBuilder.Append(header->second);

found = true;

} else {

- // TODO(rakuco): This must be ", " instead. crbug.com/700434.

- resultBuilder.Append(',');

+ resultBuilder.Append(", ");

resultBuilder.Append(header->second);

}