Some fast/table tests should wait for images specified via CSS url()

Some fast/table tests should wait for images specified via CSS url()

Some fast/table expect images specified via CSS url() specifier are loaded
before the test runner dumps the output, but it's actually not guaranteed. This
leads to test flakiness.

Currently all url() are written inline, so we can rely on the Document load
event. This CL adds resources/base.js which calls notifyDone when the event is
fired.

BUG=603396, 712930
Review-Url: https://codereview.chromium.org/2822093003
Cr-Commit-Position: refs/heads/master@{#465532}
Committed: https://chromium.googlesource.com/chromium/src/+/4e1eb3c8414a02dc9d8e289c8da105ad1fff718a

[yhirano, 2017-04-18 08:28:39]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 08:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-18 08:32:27]

yhirano@chromium.org changed reviewers:
+ kouhei@chromium.org, rune@opera.com

[yhirano, 2017-04-18 08:32:28]

PTAL

This is similar to https://bugs.chromium.org/p/chromium/issues/detail?id=675870
and https://codereview.chromium.org/2588283002.

Please note that the tests are already flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

[commit-bot: I haz the power, 2017-04-18 09:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 09:51:17]

Dry run: This issue passed the CQ dry run.

[rune, 2017-04-18 15:30:09]

The BUG reference looks wrong.

https://codereview.chromium.org/2822093003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/table/resources/base.js (right):

https://codereview.chromium.org/2822093003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/table/resources/base.js:14: 
The name "base.js" doesn't indicate what this script does, it should have a
better name.

I don't understand how you are guaranteed that the CSS resources are loaded if
they don't block onload.

[yhirano, 2017-04-19 01:24:14]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 01:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-19 01:31:34]

Description was changed from

==========
Some fast/table tests should wait for images specified via CSS url()

Some fast/table expect images specified via CSS url() specifier are loaded
before the test runner dumps the output, but it's actually not guaranteed. This
leads to test flakiness.

Currently all url() are written inline, so we can rely on the Document load
event. This CL adds resources/base.js which calls notifyDone when the event is
fired.

BUG=603396
==========

to

==========
Some fast/table tests should wait for images specified via CSS url()

Some fast/table expect images specified via CSS url() specifier are loaded
before the test runner dumps the output, but it's actually not guaranteed. This
leads to test flakiness.

Currently all url() are written inline, so we can rely on the Document load
event. This CL adds resources/base.js which calls notifyDone when the event is
fired.

BUG=603396, 712930
==========

[yhirano, 2017-04-19 01:32:50]

> The BUG reference looks wrong.

The reference is correct: I want tests less flaky from mojo-loading POV. I added
one another bug.

https://codereview.chromium.org/2822093003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/table/resources/base.js (right):

https://codereview.chromium.org/2822093003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/table/resources/base.js:14: 
On 2017/04/18 15:30:09, rune wrote:
> The name "base.js" doesn't indicate what this script does, it should have a
> better name.
> 
> I don't understand how you are guaranteed that the CSS resources are loaded if
> they don't block onload.

Done.

Resources linked from inline CSSs block the onload event.

[yhirano, 2017-04-19 01:32:51]

> The BUG reference looks wrong.

The reference is correct: I want tests less flaky from mojo-loading POV. I added
one another bug.

[kouhei (in TOK), 2017-04-19 02:28:00]

lgtm

[commit-bot: I haz the power, 2017-04-19 02:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 02:42:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-04-19 07:53:18]

lgtm

[yhirano, 2017-04-19 08:13:34]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-04-19 08:14:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 08:38:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492589614347670,
"parent_rev": "cc1bde6592ae5e0b5064e7680941569625db9d09", "commit_rev":
"4e1eb3c8414a02dc9d8e289c8da105ad1fff718a"}

[commit-bot: I haz the power, 2017-04-19 08:38:40]

Description was changed from

==========
Some fast/table tests should wait for images specified via CSS url()

Some fast/table expect images specified via CSS url() specifier are loaded
before the test runner dumps the output, but it's actually not guaranteed. This
leads to test flakiness.

Currently all url() are written inline, so we can rely on the Document load
event. This CL adds resources/base.js which calls notifyDone when the event is
fired.

BUG=603396, 712930
==========

to

==========
Some fast/table tests should wait for images specified via CSS url()

Some fast/table expect images specified via CSS url() specifier are loaded
before the test runner dumps the output, but it's actually not guaranteed. This
leads to test flakiness.

Currently all url() are written inline, so we can rely on the Document load
event. This CL adds resources/base.js which calls notifyDone when the event is
fired.

BUG=603396, 712930

Review-Url: https://codereview.chromium.org/2822093003
Cr-Commit-Position: refs/heads/master@{#465532}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e1eb3c8414a02dc9d8e289c8da1...
==========

[commit-bot: I haz the power, 2017-04-19 08:38:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e1eb3c8414a02dc9d8e289c8da1...