Most css1/ tests should wait for basebg.gif to be loaded

Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870
Committed: https://crrev.com/d16a6bc2ccee2249dec6028140ac5792c4ca991e
Cr-Commit-Position: refs/heads/master@{#439733}

[yhirano, 2016-12-20 05:47:35]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 05:48:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-12-20 05:48:43]

yhirano@chromium.org changed reviewers:
+ kouhei@chromium.org

[yhirano, 2016-12-20 06:26:08]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 06:26:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-12-20 06:34:23]

Description was changed from

==========
Most css1/ tests should wait for resources linked from CSS to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL adds waitUntilLayoutGetsStable switch to the test runner. When set,
the test runner finish tests if there're no pending resource requests in the
main document fetcher, after updating the layout.

BUG=603396
==========

to

==========
Most css1/ tests should wait for resources linked from CSS to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396
==========

[yhirano, 2016-12-20 06:35:14]

Description was changed from

==========
Most css1/ tests should wait for resources linked from CSS to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396
==========

to

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396
==========

[yhirano, 2016-12-20 06:35:49]

Based on an offline discussion I updated the change. PTAL again.

[kouhei (in TOK), 2016-12-20 06:37:19]

On 2016/12/20 06:35:49, yhirano wrote:
> Based on an offline discussion I updated the change. PTAL again.

Code change lgtm. Would you file a crbug for this specific issue and link from
CL desc?

[yhirano, 2016-12-20 06:47:07]

Description was changed from

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396
==========

to

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870
==========

[yhirano, 2016-12-20 06:47:49]

On 2016/12/20 06:37:19, kouhei wrote:
> On 2016/12/20 06:35:49, yhirano wrote:
> > Based on an offline discussion I updated the change. PTAL again.
> 
> Code change lgtm. Would you file a crbug for this specific issue and link from
> CL desc?

Done: I filed https://crbug.com/675870

[kouhei (in TOK), 2016-12-20 07:05:36]

lgtm

[yhirano, 2016-12-20 07:07:03]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-12-20 07:07:03]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-12-20 07:07:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:44:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482217623891410,
"parent_rev": "65b3c9575b5231d8a9524720720a5a6bca14e62d", "commit_rev":
"fe920c30b4d86a4d36bf95f98131c5edf74f9d2e"}

[commit-bot: I haz the power, 2016-12-20 07:44:46]

Description was changed from

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870
==========

to

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870

Review-Url: https://codereview.chromium.org/2588283002
==========

[commit-bot: I haz the power, 2016-12-20 07:44:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 07:47:02]

Description was changed from

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870

Review-Url: https://codereview.chromium.org/2588283002
==========

to

==========
Most css1/ tests should wait for basebg.gif to be loaded

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870

Committed: https://crrev.com/d16a6bc2ccee2249dec6028140ac5792c4ca991e
Cr-Commit-Position: refs/heads/master@{#439733}
==========

[commit-bot: I haz the power, 2016-12-20 07:47:04]

Patchset 2 (id:??) landed as
https://crrev.com/d16a6bc2ccee2249dec6028140ac5792c4ca991e
Cr-Commit-Position: refs/heads/master@{#439733}